Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ScopedJobThreadPtr class to be used with JobThread #4275

Open
wants to merge 1 commit into
base: 25.lts.1+
Choose a base branch
from
Open

Add ScopedJobThreadPtr class to be used with JobThread #4275

wants to merge 1 commit into from

Conversation

alexanderbobrovnik
Copy link
Collaborator

@alexanderbobrovnik alexanderbobrovnik commented Oct 17, 2024 •
edited
Loading

b/372515171

@alexanderbobrovnik alexanderbobrovnik changed the title Add explicit join thread to JobThread Add ScopedJobThreadPtr class to be used with JobThread Oct 22, 2024
@xiaomings xiaomings requested a review from borongc October 22, 2024 18:20
@xiaomings
Copy link
Contributor

@borongc is it possible for you to help me review the part in this PR where all changes to Schedule() made during the scoped_ptr<> to unique_ptr<> migration is reverted?

xiaomings
xiaomings reviewed Oct 22, 2024
View reviewed changes
starboard/shared/starboard/player/job_thread.h Outdated Show resolved Hide resolved
starboard/shared/starboard/player/job_thread.h Outdated Show resolved Hide resolved
starboard/shared/starboard/player/job_thread.h Outdated Show resolved Hide resolved
@xiaomings
Copy link
Contributor

@osagie98 @sideb0ard is it possible for you to take a look at this one?

@sideb0ard
Copy link
Contributor

@osagie98 @sideb0ard is it possible for you to take a look at this one?

looking now, re-reading bug history.

sideb0ard
sideb0ard reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@sideb0ard sideb0ard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From reading Xiaoming and Jelle's comments, specifically https://b.corp.google.com/issues/372515171#comment11
this new ScopedJobThreadPtr has the behavior we require in the correct order, i.e. finish jobs, terminate thread, set pointer to null.
However, as this PR and bug are still open, we appear to still have some lingering reservations.

Suggestion:

  • Can we first add a new test to job_thread_test.cc 'ScheduleJobDuringShutdown', which specifically triggers the DCHECK listed in https://b.corp.google.com/issues/372515171#comment1
    This new test should FAIL with the current implementation.
  • Then, secondly, run the new test with this PR, which should PASS. If it does pass, then we can be sure it's solved the issue as we currently understand it.

@alexanderbobrovnik
Copy link
Collaborator Author

From reading Xiaoming and Jelle's comments, specifically https://b.corp.google.com/issues/372515171#comment11 this new ScopedJobThreadPtr has the behavior we require in the correct order, i.e. finish jobs, terminate thread, set pointer to null. However, as this PR and bug are still open, we appear to still have some lingering reservations.

Suggestion:

* Can we first add a new test to job_thread_test.cc 'ScheduleJobDuringShutdown', which specifically triggers the DCHECK listed in https://b.corp.google.com/issues/372515171#comment1
  This new test should FAIL with the current implementation.

* Then, secondly, run the new test with this PR, which should PASS. If it does pass, then we can be sure it's solved the issue as we currently understand it.

I've created PR for ScheduleJobDuringShutdown test: #4864

@sideb0ard
Copy link
Contributor

I've created PR for ScheduleJobDuringShutdown test: #4864

perfect, thank you!
Rather than merge #4864 which breaks the build, as expected:

image

Lets go ahead and add that test to this PR, which should now pass with these changes.

@sideb0ard sideb0ard mentioned this pull request Feb 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideb0ard sideb0ard sideb0ard left review comments

@jellefoks jellefoks jellefoks left review comments

@xiaomings xiaomings xiaomings left review comments

@amurovanyi amurovanyi amurovanyi approved these changes

@jasonzhangxx jasonzhangxx Awaiting requested review from jasonzhangxx

@borongc borongc Awaiting requested review from borongc

@osagie98 osagie98 Awaiting requested review from osagie98

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexanderbobrovnik @xiaomings @sideb0ard @jellefoks @amurovanyi